x86/static-call: Remove early_boot_irqs_disabled check to fix Xen PVH dom0
authorAndrew Cooper <andrew.cooper3@citrix.com>
Sat, 21 Dec 2024 21:10:46 +0000 (21:10 +0000)
committerBen Hutchings <benh@debian.org>
Mon, 24 Feb 2025 01:11:58 +0000 (02:11 +0100)
commit7397a0ed4deda8114c6e8b90412de7f02aa1ab47
tree0f1e3a855fbbdf3487a5d4c116e88993cbbcbccb
parent02e59ac228d127e47d5d3d62c97711f566836414
x86/static-call: Remove early_boot_irqs_disabled check to fix Xen PVH dom0

commit 5cc2db37124bb33914996d6fdbb2ddb3811f2945 upstream.

__static_call_update_early() has a check for early_boot_irqs_disabled, but
is used before early_boot_irqs_disabled is set up in start_kernel().

Xen PV has always special cased early_boot_irqs_disabled, but Xen PVH does
not and falls over the BUG when booting as dom0.

It is very suspect that early_boot_irqs_disabled starts as 0, becomes 1 for
a time, then becomes 0 again, but as this needs backporting to fix a
breakage in a security fix, dropping the BUG_ON() is the far safer option.

Fixes: 0ef8047b737d ("x86/static-call: provide a way to do very early static-call updates")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219620
Reported-by: Alex Zenla <alex@edera.dev>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Alex Zenla <alex@edera.dev>
Link: https://lore.kernel.org/r/20241221211046.6475-1-andrew.cooper3@citrix.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gbp-Pq: Topic bugfix/x86
Gbp-Pq: Name x86-static-call-remove-early_boot_irqs_disabled-check-to-fix-xen-pvh-dom0.patch
arch/x86/kernel/static_call.c